Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Import isPlainObject directly from lodash #14307

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Core: Import isPlainObject directly from lodash #14307

merged 1 commit into from
Mar 23, 2021

Conversation

damianstasik
Copy link
Contributor

What I did

I changed how isPlainObject is imported from lodash, so that it directly imports the module instead of importing it from main module with many other exported modules.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

shilman
shilman approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good catch @visualfanatic !

Storybook_Benchmark_›_Explorer__Browse_

cc @ghengeveld pls import directly from the lodash modules

@shilman shilman changed the title fix(client-api): import isPlainObject directly from lodash Core: Import isPlainObject directly from lodash Mar 23, 2021
@shilman shilman merged commit f801006 into storybookjs:next Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug core performance issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damianstasik @shilman @visualfanatic