Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack: Fix missing module mainField #14271

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Webpack: Fix missing module mainField #14271

merged 4 commits into from
Mar 19, 2021

Conversation

ndelangen
Copy link
Member

Issue: #14269

What I did

  • I added the module to moduleFields for webpack to pick up esm entrypoints of packages.

@ndelangen ndelangen removed the request for review from stijnkoopal March 18, 2021 14:38
@ndelangen ndelangen self-assigned this Mar 18, 2021
@shilman shilman changed the title Fix/14269 module mainfield missing Core: Fix module mainField missing Mar 18, 2021
@shilman shilman changed the title Core: Fix module mainField missing Core: Fix missing module mainField Mar 18, 2021
@shilman shilman changed the title Core: Fix missing module mainField Webpack: Fix missing module mainField Mar 18, 2021
shilman
shilman approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. good catch!! 😅

@shilman shilman merged commit ae910f8 into next Mar 19, 2021
@shilman shilman deleted the fix/14269-module-mainfield-missing branch March 19, 2021 02:15
@shilman shilman mentioned this pull request Mar 19, 2021
Closed
@irudoy irudoy mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
bug configuration babel / webpack core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman