Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Improve default webpack config #14235

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

j3rem1e
Copy link
Contributor

@j3rem1e j3rem1e commented Mar 15, 2021

Issue: #14221

What I did

Added 'svelte' in the webpack mainFields, in the first position.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@j3rem1e j3rem1e force-pushed the svelte-default-config branch from 17d278e to 983d5b0 Compare March 15, 2021 13:42
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. i guess? :)

@j3rem1e
Copy link
Contributor Author

j3rem1e commented Mar 15, 2021

I don't know why, but mainFields was set when running storybook but not with build-storybook.

Moreover, I couldn't use your suggestion, because when mainFields is null, it uses default values, but not when it's set. I can't just add 'svelte' without adding the default values (I had compilation errors without).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants