-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs/Vue: Fix string docgen #14200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the presence of func means we're in vue? Seems a little brittle, but the real solution is probably a major refactor so I can live with it.
description: 'Hey! Hey!', | ||
defaultValue: { | ||
value: "'Default'", | ||
func: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is func
always false
in these cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose func
is probably true when you are using one of them vue default value "generators". I haven't explored the full space of everything vue can do though :/
Co-authored-by: Michael Shilman <[email protected]>
Yeah, given the plan is to drop all this default value shenanigans in 6.3, my feeling is we just do what's easiest for now, especially given a refactor this close to 6.2 would be a bit scary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue: #14056
What I did
Ensure we don't accidentally try and fix
react-docgen-typescript
when we are in vueHow to test