Controls: Remove auto inference and add to CLI template #14182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
commented
Mar 9, 2021
| @@ -19,6 +19,12 @@ function configurePreview(framework: SupportedFrameworks) { | |||
| const parameters = ` | |||
| export const parameters = { | |||
| actions: { argTypesRegex: "^on[A-Z].*" }, | |||
| controls: { | |||
There was a problem hiding this comment.
we could maybe add a link to the docs as a comment?
There was a problem hiding this comment.
great idea, let's follow up when the new docs are live
shilman
approved these changes
Mar 9, 2021
shilman
changed the title
2 tasks
This was referenced Mar 11, 2021
Merged
Closed
Closed
Closed
Bump @storybook/addon-actions from 6.2.0-alpha.22 to 6.2.0-beta.14
openlattice/lattice-fabricate#743
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Merged
JReinhold
added a commit
to JReinhold/storybook
that referenced
this pull request
Jul 16, 2022
A PR at storybookjs#14182 removed the default custom regex matchers for colors and dates Controls, and instead added them to the generated output from the CLI. However the docs don't reflect this change, and felt quite confusing for me working in a project that didn't use a recent version of the CLI, and therefore didn't have the "default" matchers from the CLI. I've tried to change the wording to reflect that they are only "defaults" if the reader actually sees them in the `.storybook/preview.js` file. I'm open to inputs on wording, or basically anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14014
What I did
Seems like the controls matchers as a preset were causing confusion, so this PR removes them and explicitly adds them in the CLI templates for discoverability.
How to test
1 - checkout the branch
2 - run yarn bootstrap && yarn start
3 - Check the examples at
examples/official-storybook/stories/addon-controls.stories.tsx, they should still work