Misc: Clean TS config and bump @storybook/preset-create-react-app
#13878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
requested review from
alterx,
igor-dv,
ndelangen and
usulpro
as code owners
phated
approved these changes
Feb 11, 2021
`skipDefaultLibCheck` is deprecated so there is no need to add it anymore. I added `skipLibCheck` in the angular example because it looks like there are some type incompatibility between some types coming from node_modules we have in the monorepo. (Not really a surprise with the number of deps we have) Signed-off-by: Gaëtan Maisse <[email protected]>
…ssing it Latest version of `@storybook/preset-create-react-app` fix some issue when working with workspaces
gaetanmaisse
force-pushed
the
tech/fix-dependencies
branch
from
3bca4b5 to
013a42a
Compare
|
@phated I will merge with that alpha version, it will also help us testing everything is fine with it and then bump it as soon as a stable version will be released. |
|
@gaetanmaisse do you need me to release a stable? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #13559 step by step to not face gigantic conflicts or issues with the webpack 4/5 works.
What I did
I cleaned usage of
skipLibCheckandskipDefaultLibCheckTS option:skipDefaultLibCheckis deprecated so there is no need to add it anymore. I addedskipLibCheckin the angular example because with Yarn 2 it looks like there is type incompatibility between some types coming from node_modules we have in the monorepo. (Not really a surprise with the number of deps we have, but I don't know why it is currently working with Yarn 1, magic hoisting 🤷🏻 )I added
@storybook/preset-create-react-appwhere it was missing and use the latest alpha to get the fix from preset-create-react-app: Fix monorepos and PnP presets#181How to test