Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix ArgsTable tab renamed to Story when using args #13845

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Addon-docs: Fix ArgsTable tab renamed to Story when using args #13845

merged 1 commit into from
Feb 20, 2021

Conversation

somenickname
Copy link

Issue: #12357

What I did

Used component name for first tab of ArgsTable instead of hardcoded "Story" title

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

shilman
shilman approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for the fix!

@somenickname somenickname mentioned this pull request Feb 11, 2021
Closed
@shilman shilman changed the title Fix first tab renamed to Story when using args Addon-docs: Fix ArgsTable tab renamed to Story when using args Feb 20, 2021
@shilman shilman merged commit 3ea21b7 into storybookjs:next Feb 20, 2021
@somenickname somenickname deleted the 12357_fix_first_tab_named_story branch February 22, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs block: argstable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somenickname @shilman