Build: Exclude more files from transpilation, generate versions with preval, and enable deepscan in workspace #13712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
requested review from
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
igor-dv,
jbovenschen,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
stijnkoopal,
theinterned,
tmeasday and
z4o4z
as code owners
|
I've stumbled upon kentcdodds/babel-plugin-preval#19 - which makes me think the preval thing is a non-starter. I'll probably back out that change. |
|
Closing in favor of individual PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11220
What I did
I recreated #11220 by rebasing and splitting up the commits a bit. I didn't include the node 8 -> 10 changes because I want to do that in a separate PR.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.