Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Properly handle empty tsconfig compilerOptions #13596

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

matheo
Copy link
Member

@matheo matheo commented Jan 10, 2021

Issue:

What I did

Considered the case when tsconfig is extending another file and has an empty compilerOptions.

This avoid an exception like:

image

@matheo matheo requested review from alterx and igor-dv as code owners January 10, 2021 01:00
@matheo matheo added angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 10, 2021
@matheo matheo requested a review from shilman January 11, 2021 14:10
@gaetanmaisse gaetanmaisse requested a review from a team January 12, 2021 20:23
@gaetanmaisse
Copy link
Member

I think we can merge this one but we need to plan some more work about the TS config, sum up of discussion I had with @ThibaudAV: we should follow the extends key to find the parent tsconfig.json and build the resulting one to be sure all the options/configs are taking into account.

@gaetanmaisse gaetanmaisse changed the title fix(angular): consider empty tsconfig compilerOptions Angular: properly handle empty tsconfig compilerOptions Jan 21, 2021
@gaetanmaisse gaetanmaisse changed the title Angular: properly handle empty tsconfig compilerOptions Angular: Properly handle empty tsconfig compilerOptions Jan 21, 2021
@gaetanmaisse gaetanmaisse merged commit 60f6b40 into storybookjs:next Jan 21, 2021
@shilman shilman added bug patch:done Patch/release PRs already cherry-picked to main/release branch labels Jan 22, 2021
shilman pushed a commit that referenced this pull request Jan 22, 2021
Angular: Properly handle empty tsconfig compilerOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants