-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Properly handle empty tsconfig compilerOptions #13596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheo
added
angular
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Jan 10, 2021
I think we can merge this one but we need to plan some more work about the TS config, sum up of discussion I had with @ThibaudAV: we should follow the |
gaetanmaisse
approved these changes
Jan 12, 2021
gaetanmaisse
changed the title
fix(angular): consider empty tsconfig compilerOptions
Angular: properly handle empty tsconfig compilerOptions
Jan 21, 2021
gaetanmaisse
changed the title
Angular: properly handle empty tsconfig compilerOptions
Angular: Properly handle empty tsconfig compilerOptions
Jan 21, 2021
shilman
added
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
labels
Jan 22, 2021
shilman
pushed a commit
that referenced
this pull request
Jan 22, 2021
Angular: Properly handle empty tsconfig compilerOptions
This was referenced Mar 8, 2021
Closed
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
angular
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Considered the case when
tsconfig
is extending another file and has an emptycompilerOptions
.This avoid an exception like: