Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix typing of dev CLI options #13501

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Core: Fix typing of dev CLI options #13501

merged 1 commit into from
Dec 22, 2020

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Dec 22, 2020 •
edited
Loading

What I did

The mistake was spotted in 1394788#r45325210

I fixed the type by setting host to string

How to test

  • Build should be ok

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks core labels Dec 22, 2020
@gaetanmaisse gaetanmaisse marked this pull request as ready for review December 22, 2020 07:32
gaetanmaisse referenced this pull request Dec 22, 2020
@gaetanmaisse
refactor(core): improve typings of server/cli
1394788
shilman
shilman approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman added this to the 6.2 maintenance milestone Dec 22, 2020
@shilman shilman merged commit 59ee9c3 into next Dec 22, 2020
@shilman shilman deleted the tech/fix-core-typings branch December 22, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
6.2 maintenance
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetanmaisse @shilman @D448-lang