Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix Yarn 2 E2E tests #13129

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Build: Fix Yarn 2 E2E tests #13129

merged 3 commits into from
Nov 16, 2020

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Nov 16, 2020 •
edited
Loading

What I did

  • use an unreleased version of Yarn 2 to fix the issue with fsevents patch
  • update missing package extensions for Yarn 2 tests
  • add react as additionalDeps in sfcVue E2E tests to tmp fix Yarn 2 E2E tests

How to test

  • CI job example-v2-yarn-2 should be 🟢

@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Nov 16, 2020
@gaetanmaisse gaetanmaisse changed the title Misc: Fix Yarn 2 E2E tests Build: Fix Yarn 2 E2E tests Nov 16, 2020
@gaetanmaisse gaetanmaisse marked this pull request as ready for review November 16, 2020 16:30
@gaetanmaisse gaetanmaisse requested a review from shilman November 16, 2020 16:30
shilman
shilman approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@shilman shilman merged commit a40349c into next Nov 16, 2020
@shilman shilman deleted the fix-yarn-2-tests branch November 16, 2020 16:33
@gaetanmaisse gaetanmaisse mentioned this pull request Nov 16, 2020
Closed
@merceyz merceyz mentioned this pull request Nov 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @shilman