Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix spurious warnings #13075

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Addon-docs: Fix spurious warnings #13075

merged 2 commits into from
Nov 10, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 10, 2020

Issue: #13074

What I did

  • Removed a spurious source warning (see comment)
  • Deduplicated storyFn is deprecated warnings on docs page

NOTE: Docs needs to be rearchitected to render async functions, so the warning is valid. @tmeasday it would be nice to get a fix in--maybe using React suspense?--but seems like a 6.2 change. WDYT?

How to test

See official-storybook

@shilman shilman added this to the 6.1 docs milestone Nov 10, 2020
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second part LGTM, might need to chat about the first part

@shilman shilman merged commit 75f0fe9 into next Nov 10, 2020
@shilman shilman deleted the 13074-fix-docs-warnings branch November 10, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants