-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon-docs: Added a button to refresh component #13024
addon-docs: Added a button to refresh component #13024
Conversation
I would implement this by emitting an event probably. I'm not really sure about the feature -- it sounds like something that an addon should do, but I guess we don't currently have a way for an addon to add buttons here. |
Unclear about the use case. Is the use case refreshing components that animateIn? |
That's right. You won't have to reload your browser when you want to check the animation. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hello @toshi1127 Thank you for contributing! We're really appreciating the time, effort and energy you've put into this. I think the idea of re-running a story / remounting it is a good one. It's a should become a feature of storybook IMHO, especially now that we play functions. I'll bring this up in the next roadmap meeting for 7.0 (you're welcome to join!) and see how we want to implement this feature in 7.0. Unfortunately I think this PR isn't the way to the implementation of the feature, because this only works for docs and only really works for react. |
Issue: #12101
What I did
Added a button to refresh component.
How to test
Is this testable with Jest or Chromatic screenshots?
yes.
I added animation to the component and made sure they were refreshed.
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?