Combine args with basic object spread semantics #12958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
commented
Oct 30, 2020
| arg1: 4, | ||
| arg2: undefined, | ||
| arg3: 3, | ||
| arg4: { other: 'object ' }, |
There was a problem hiding this comment.
NOTE: previously this used to combine the object!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12697
Issue: We (implicitly) used
combineParametersto combine component & story-level args, which has complex object-combination semantics that I don't think we wanted.What I did
Just use object spread.
NOTE: this is technically a breaking change, fixing a bug. However people may be relying on that bug. Not sure what to do about that.
How to test
There's a test.