Core: Allow React-DOM 17.x #12937
Merged
Core: Allow React-DOM 17.x #12937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alexandrebodin,
alterx,
CodeByAlex,
igor-dv,
jbovenschen,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
Hypnosphi
requested changes
Oct 28, 2020
There was a problem hiding this comment.
Same issue as #12908 (comment). Doing this basically means dropping React 16 support, because nothing prevents NPM from installing React 17 as package dependencies even if user app uses 16.
We really should make those peer dependencies again
|
I agree with @Hypnosphi on this, but understand that isn't a quick change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Follow-up to #12908
See #12908 (comment)