-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search to docs #1256
Added search to docs #1256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 13.71% 13.71%
=======================================
Files 207 207
Lines 4646 4646
Branches 512 583 +71
=======================================
Hits 637 637
+ Misses 3553 3519 -34
- Partials 456 490 +34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great--super clean integration!
Visually I'd like to get the "social proof" higher up on the page, so I'd prefer to swap it vertically with "used by".
Looking at https://www.styled-components.com/ as a reference.
@SachaG any thoughts on a visual cleanup here, now that we are getting more stuff on the homepage?
Sounds pretty easy to do what you want @shilman But would you mind doing it? I have the feeling you know how you want it, and I don't want this to take too long. Not being able to search on documentation sites drives me mad 😜 |
Issue: #1177
What I did
I added the search field on the home page and connected it to algolia.
How to test