Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search to docs #1256

Merged
merged 4 commits into from
Jun 16, 2017
Merged

Added search to docs #1256

merged 4 commits into from
Jun 16, 2017

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 11, 2017

Issue: #1177

What I did

I added the search field on the home page and connected it to algolia.

How to test

  • run docs locally
  • open homepage
  • type in a search query into the search field

@ndelangen ndelangen added this to the v3.1.4 milestone Jun 11, 2017
@ndelangen ndelangen self-assigned this Jun 11, 2017
@ndelangen ndelangen requested review from SachaG and shilman June 11, 2017 20:11
@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #1256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1256   +/-   ##
=======================================
  Coverage   13.71%   13.71%           
=======================================
  Files         207      207           
  Lines        4646     4646           
  Branches      512      583   +71     
=======================================
  Hits          637      637           
+ Misses       3553     3519   -34     
- Partials      456      490   +34
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 38.57% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253ce66...c7ba1a2. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great--super clean integration!

Visually I'd like to get the "social proof" higher up on the page, so I'd prefer to swap it vertically with "used by".

Looking at https://www.styled-components.com/ as a reference.

@SachaG any thoughts on a visual cleanup here, now that we are getting more stuff on the homepage?

@ndelangen
Copy link
Member Author

Sounds pretty easy to do what you want @shilman But would you mind doing it?

I have the feeling you know how you want it, and I don't want this to take too long.

Not being able to search on documentation sites drives me mad 😜

@ndelangen ndelangen dismissed shilman’s stale review June 16, 2017 06:53

We will redesign later

@ndelangen ndelangen merged commit b244f99 into master Jun 16, 2017
@ndelangen ndelangen deleted the add-search-to-docs branch June 16, 2017 07:28
@shilman shilman changed the title Add search to docs Added search to docs Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants