React: Fix fast refresh #12535
Merged
React: Fix fast refresh #12535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rather than in the webpack config, set it in babel, so that there aren't multiple loaders and instead just the plugin is added together with the presets. Examples were moved to cra-kitchen-sink because official removes the babel-loader taht comes from storybook.
yannbf
requested review from
alterx,
igor-dv,
ndelangen,
shilman,
thomasbertet,
tmeasday and
usulpro
as code owners
|
Awesome! |
ndelangen
approved these changes
Sep 21, 2020
shilman
changed the title
shilman
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In 6.1 alpha, support for React fast refresh was added. Unfortunately the fast refresh config ended up adding a new babel-loader rather than integrating the rules with the existing loader. This PR fixes that by separating the webpack and babel work in the react preset.
The fast refresh example component + story was moved from official-storybook to cra-kitchen-sink, given that the official-storybook is deliberately removing the babel loader and adding a custom one.
How to test
yarn bootstrapyarn --cwd examples/cra-kitchen-sink storybookand tweak with either the reactOptions in main.js or add REACT_REFRESH=true then change to false in the.envfile.