Core: Add prefix customization for navigation items

[tooppaaa]

Issue: Lack of capability to add elements to

• sidebar subheadings (most important one in my opinion)
• sidebar items
  • folder
  • component
  • story

This PR aims as a proposal for this and basis of discussions

• Should we keep double icons when prefix is set ?
• Should it be called prefix ?

[shilman]

cc @domyen @ghengeveld

[shilman]

Looks great & code is pretty simple. Great stuff @tooppaaa 💯

We're doing some work on the sidebar as part of the search stuff and I want to make sure this is compatible with that work before we merge it. My spider sense is tingling that we'll want to address this in a different way, but don't have a concrete suggestion yet.

[tooppaaa]

Happy to wait / change implementation !
As I mentioned, this is simple "suggestion PR" where we can see whether we want this or not :)

[ghengeveld]

I'm working on a revamp of the sidebar right now. Allowing customization is on the radar and the current proposal is to allow this by setting data attributes on relevant nodes for various things. That allows these elements to be targeted with CSS and read the data values from JS.

@tooppaaa would this work for you? Do you have other suggestions?

I'm not so keen on adding a prefix attribute because it's very use case specific. I'd rather have a more generic solution which plugins can hook into to add such a prefix that way.

[ghengeveld]

@tooppaaa I can share the redesign strawman with me you if you'd like. Just send me your Google account address on which to invite you. I think you follow me on Twitter. Or drop a note in the chat bubble at https://www.chromatic.com/docs

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[tooppaaa]

@ghengeveld Should we drop that PR ?

[ndelangen]

I think the idea on this PR is great, @tooppaaa I think it's worth continuing in concept, but perhaps it'd be easier to start anew rather then try and fix the merge-conflicts?

[tooppaaa]

Reworked as #13121