Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Fix reactDocgen option when false #12492

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

AndrewLeedham
Copy link
Contributor

Issue: #12491

What I did

  • Stopped babel-plugin-react-docgen being added when typescript.reactDocgen option is set to false.
  • Updated the typescript docs to reflect change (no more "none" option, which did not seem to do anything).
  • Added tests for the false case as well as the "react-docgen-typescript" case.

@shilman shilman changed the title fix(react): reactDocgen option when false React: Fix reactDocgen option when false Sep 16, 2020
@shilman shilman added this to the 6.0.x milestone Sep 16, 2020
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 16, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix! 🙏

@shilman shilman merged commit cb87bc1 into storybookjs:next Sep 16, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 26, 2020
shilman added a commit that referenced this pull request Sep 26, 2020
React: Fix reactDocgen option when false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants