Addon-docs: Fix MDX IDs from CSF imports #12154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12143
This is technically a breaking change but I'd like to treat it as a bugfix since the feature is brand new.
What I did
This is a cheap/hacky way to make sure that the variable is unique.
Consider the following MDX:
The compiler was generating the following code (simplified):
If I made the export named
foo
, it would collide with the import name and the generated code would be invalid. However, this modified the Story ID.This PR modifies the generated code to be:
Which preserves the same ID.
How to test
See attached snapshot & CSF imported MDX example in
official-storybook
.