Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add CSF types for Angular #11825

Merged
merged 4 commits into from
Aug 7, 2020
Merged

CLI: Add CSF types for Angular #11825

merged 4 commits into from
Aug 7, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Aug 6, 2020

Issue: No typings for Angular

What I did

Add typings for angular same way we did for react

How to test

  • E2E

@shilman shilman changed the title cli: apply types for angular CLI: Add CSF types for Angular Aug 7, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit b8dc123 into next Aug 7, 2020
@shilman shilman mentioned this pull request Aug 9, 2020
14 tasks
@shilman shilman added this to the 6.0 milestone Aug 9, 2020
@shilman shilman mentioned this pull request Aug 17, 2020
3 tasks
@stof stof deleted the cli/typesAngular branch May 25, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants