ArgsTable: Fix styles to allow long text to wrap #11818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep short text from wrapping
cfhull
commented
Aug 5, 2020
| @@ -30,10 +30,11 @@ const Summary = styled.div<{ isExpanded?: boolean }>(({ isExpanded }) => ({ | |||
| flexWrap: 'wrap', | |||
| alignItems: 'flex-start', | |||
| marginBottom: '-4px', | |||
| minWidth: 100, | |||
There was a problem hiding this comment.
This value is a bit arbitrary. Without it, a short string like default would wrap the lt to the next line. 100px min width seemed small enough to me that the column wouldn't be overly big if there were no defaults, but would keep relatively short values from breaking to a new line.
|
@cfhull thank you I hit the same issue |
ndelangen
approved these changes
Aug 17, 2020
|
@shilman review? |
shilman
approved these changes
Aug 17, 2020
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11362
What I did
This PR, while doing some awesome things, doesn't resolve the word wrapping issue.
Specifically, the new
word-break: break-allproperty conflicts with the existingword-wrap: nowrapproperty that is inherited fromstyles.span. I also added a min-width to keep it from breaking on short words.Current behavior:
New behavior:
How to test