Addon-controls: Fix update logic for argTypes with custom names #11704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My sense is that |
jonspalmer
force-pushed
the
controls_update_name_not_key
branch
from
7309560 to
beccf74
Compare
jonspalmer
force-pushed
the
controls_update_name_not_key
branch
from
beccf74 to
28b64b6
Compare
jonspalmer
commented
Jul 29, 2020
| @@ -32,20 +32,20 @@ export const ArgControl: FC<ArgControlProps> = ({ row, arg, updateArgs }) => { | |||
| }, [isFocused, arg]); | |||
|
|
|||
| const onChange = useCallback( | |||
| (argName: string, argVal: any) => { | |||
| (argVal: any) => { | |||
There was a problem hiding this comment.
I don't see any reason for the callback to have the key. Before we were ignoring it anyway. The Controls shouldn't need to know this detail.
| ); | ||
|
|
||
| const onBlur = useCallback(() => setFocused(false), []); | ||
| const onFocus = useCallback(() => setFocused(true), []); | ||
|
|
||
| if (!control || control.disable) return <NoControl />; | ||
|
|
||
| const props = { name, argType: row, value: boxedValue.value, onChange, onBlur, onFocus }; | ||
| // row.name is a display name and not a suitable DOM input id or name - i might contain whitespace etc. | ||
| // row.key is a hash key and therefore a much safer choice |
There was a problem hiding this comment.
@shilman and I discussed adding a key prop (which would actually have to be argKey as key is a React reserved property). However, with the onChange adjustment its mostly unnecessary. We're really intending to hand in something that can be used as a DOM Input id/name. This makes for a much smaller change
shilman
approved these changes
Jul 29, 2020
shilman
changed the title
This was referenced Nov 17, 2020
This was referenced Nov 18, 2020
This was referenced Jun 23, 2023
This was referenced Nov 30, 2023
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controls with a name don't update when changed. Failing test case against Official Storybook.
What I did
nameprop.How to test
/?path=/story/controls-boolean--basic/?path=/story/core-args--passed-to-story