Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Skip dynamic source rendering when not needed #11640

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Addon-docs: Skip dynamic source rendering when not needed #11640

merged 3 commits into from
Jul 22, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 22, 2020

Issue: N/A

What I did

Follow-up to #11601

If we're not going to use the dynamically rendered source snippet, don't even bother rendering it.

How to test

See official-storybook

@shilman shilman modified the milestones: 6.1 docs, 6.0 docs Jul 22, 2020
tmeasday
tmeasday reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really follow the logic can you explain in a comment?

It feels like the same checks as lower are being down here

tmeasday
tmeasday approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@shilman shilman merged commit 4d4e803 into next Jul 22, 2020
@stof stof deleted the docs-source-optimize-dynamic-rendering branch May 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: docs block: source bug performance issue
Projects
None yet
Milestone
6.0 docs
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday