Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix prefix redirect #11637

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Core: Fix prefix redirect #11637

merged 4 commits into from
Jul 22, 2020

Conversation

tmeasday
Copy link
Member

Issue: #11571

Two problems:

  1. We were unnecessarily emitting SET_CURRENT_STORY on startup which lead to the the back-and-forward behaviour
  2. We didn't take into account that one storyId could be a prefix of the other (which led to the redirection)

What I did

Fix above

How to test

See unit test and new stories.

@tmeasday tmeasday requested a review from shilman July 22, 2020 04:01
@tmeasday tmeasday added the bug label Jul 22, 2020
@shilman shilman added the core label Jul 22, 2020
@shilman shilman added this to the 6.0 milestone Jul 22, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Fix prefix redirect Core: Fix prefix redirect Jul 22, 2020
@shilman shilman merged commit 28e65b0 into next Jul 22, 2020
@ndelangen ndelangen deleted the 11571-fix-prefix-redirect branch July 22, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants