Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Optimize storiesHash by removing unused parameters #11624

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Core: Optimize storiesHash by removing unused parameters #11624

merged 3 commits into from
Jul 21, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 21, 2020 •
edited
Loading

Issue: #11618 #11229

What I did

storiesHash is the manager-side version of the story store. Currently it's doing a bunch of unnecessary work merging story parameters up the hierarchy of stories/groups/roots, which can be slow for storybooks with large sets of parameters.

With @ndelangen:

  • Removed parameters for the root node (which we believe is safe)
  • Only propagate viewMode and docsOnly parameters up the tree, as they are used in group nodes

Performance implications

We saw a minor perf improvement on official-storybook. We assume this would be more pronounced for a more parameter-heavy/deeply nested storybook:

  • Before: setStories = 885ms
  • After: setStories = 640ms

How to test

  • CI / updated snapshots
  • Run official-storybook and verify
    • Search
    • Docs-only stories
    • View-mode stories

@shilman shilman added this to the 6.0 milestone Jul 21, 2020
tmeasday
tmeasday approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit fd511fc into next Jul 21, 2020
This was referenced Jul 21, 2020
Closed
Closed
This was referenced Dec 15, 2021
Closed
Closed
This was referenced Apr 7, 2022
Closed
Closed
Closed
@stof stof deleted the 11618-optimize-stories-hash branch May 25, 2022 09:30
@snyk-bot snyk-bot mentioned this pull request May 25, 2022
Open
This was referenced Jun 2, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 19, 2023
Open
@lili2311 lili2311 mentioned this pull request Jun 23, 2023
Open
@lili2311 lili2311 mentioned this pull request Aug 11, 2023
Open
This was referenced Sep 25, 2023
Open
Open
This was referenced Nov 25, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday tmeasday approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @tmeasday @ndelangen