CHANGE to use getDataForManager over extract api on storyStore #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
reviewed
Jul 17, 2020
tmeasday
requested changes
Jul 17, 2020
|
Although maybe we should add that code to the store itself so you call call |
|
maybe just |
…ANGE cli extract command to use it
shilman
reviewed
Jul 17, 2020
lib/client-api/src/story_store.ts
Outdated
| @@ -569,6 +570,35 @@ export default class StoryStore { | |||
| }; | |||
| }; | |||
|
|
|||
| getStoriesJsonData = () => { | |||
| const value = this.getDataForManager(); | |||
| const allowed = ['fileName', 'docsOnly', 'framework', '__id']; | |||
There was a problem hiding this comment.
Do we need to know that for the sidebar?
tmeasday
approved these changes
Jul 18, 2020
|
Cool I added a test as well |
ndelangen
deleted the
tech/change-sbextract-cli-command-to-use-better-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11302
What I did
I improved the
sb extractcli command to use a better StoryStore api.