-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition: Allow refs versions in config #11294
Conversation
# Conflicts: # lib/api/src/version.ts # lib/cli/versions.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ndelangen which takes precedence? The user specified one or the I think the user one should (also people might want an easy way to cull the list of versions without manually spec-ing URLs). But this can come later I am thinking. |
metadata.json would take precedence if it was loaded |
Issue: -testing versions is hard- also -users might manually know their list of versions-
What I did
I made it possible for users to specify in main.js their list of versions fr a ref!