-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition QA #11224
Merged
Merged
Composition QA #11224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domyen
added
ui
cleanup
Minor cleanup style change that won't show up in release changelog
labels
Jun 18, 2020
# Conflicts: # lib/ui/src/components/sidebar/RefBlocks.tsx
# Conflicts: # lib/components/src/Button/Button.tsx
This reverts commit 37b4df5.
@ndelangen found some issues that I could use a hand with: Bugs
Reorg "Refs" stories for visual testing Strawman:
|
# Conflicts: # lib/cli/versions.json
# Conflicts: # lib/components/src/Button/Button.tsx
I'm on it now, I'll do:
|
ndelangen
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This PR polishes Storybook Composition.
What I did
I adjusted the Composition UI so that it matches the design. Also tweaked some Sidebar and Button styles that affected Composition.
How to test
Bugs that need fixing