Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition QA #11224

Merged
merged 26 commits into from
Jun 30, 2020
Merged

Composition QA #11224

merged 26 commits into from
Jun 30, 2020

Conversation

domyen
Copy link
Member

@domyen domyen commented Jun 18, 2020

Issue:
This PR polishes Storybook Composition.

What I did

I adjusted the Composition UI so that it matches the design. Also tweaked some Sidebar and Button styles that affected Composition.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

Bugs that need fixing

  • Sidebar:Dark with refs does not get rendered and snapshotted by Chromatic
  • Clicking on a new version collapses the ref when it should not
  • "View Docs" link does not work

@domyen domyen added ui cleanup Minor cleanup style change that won't show up in release changelog labels Jun 18, 2020
@domyen domyen requested a review from ndelangen June 18, 2020 00:58
@domyen domyen requested review from igor-dv and tmeasday as code owners June 18, 2020 00:58
@domyen domyen changed the title Composition styling QA Composition QA Jun 23, 2020
@domyen
Copy link
Member Author

domyen commented Jun 24, 2020

@ndelangen found some issues that I could use a hand with:

Bugs

Reorg "Refs" stories for visual testing
Instead of having all the refs states printed in Sidebar:With Refs, can we decompose the refs into separate stories? That would make regression detection more granular/effective.

Screenshot 2020-06-24 15 55 53

Strawman:

  • Keep Sidebar/Sidebar: With Refs, but only show one representative Ref
  • Add Sidebar/Refs: ref name for each ref

@ndelangen
Copy link
Member

Yes, I'll work on that @dom
I'll focus on getting #11295 merged first

@ndelangen
Copy link
Member

ndelangen commented Jun 30, 2020

I'm on it now, I'll do:

  • "View Docs" link does not work
  • Clicking on a new version collapses the ref when it should not
  • Reorg "Refs" stories for visual testing

@ndelangen ndelangen merged commit e313d77 into next Jun 30, 2020
@ndelangen ndelangen deleted the composition-styling-qa branch June 30, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants