-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-controls: Angular support #10946
Conversation
@shilman I can help with this, I just need to be able to build:watch and link the built package locally to my project without verdaccio, is it possible? |
Thanks @matheo I'm almost done with this -- making a few last-minute tweaks and will merge/release in the next 1-2h. To try it out, follow the instructions in |
Great news, I will test this out and help to fix any issue that I may find. BTW, can we add |
@shilman sounds good! addons/controls/src/register.tsx
-import { ADDON_ID } from './constants';
+import { ADDON_ID, PARAM_KEY } from './constants';
addons.register(ADDON_ID, (api: API) => {
addons.addPanel(ADDON_ID, {
title: 'Controls',
type: types.PANEL,
+ paramKey: PARAM_KEY, to support |
@matheo Aha, didn't know about |
Self-merging @tmeasday |
Issue: #10583 #10956
What I did
Partial support for angular:
How to test
See
angular-cli
stories and added test cases