Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: parallel execution on build package scripts #10808

Merged
merged 2 commits into from
May 17, 2020

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 16, 2020

What I did

This PR adds:

  • Parallel execution when using yarn build on watch mode internally in the storybook repo
  • Warning log when running --all together with --watch

How to test

1 - Checkout the branch
2 - Run yarn build --all
3 - Run yarn build --all --watch

@yannbf yannbf added the maintenance User-facing maintenance tasks label May 16, 2020
@yannbf yannbf requested review from igor-dv and ndelangen as code owners May 16, 2020 15:16
@yannbf yannbf self-assigned this May 16, 2020
@yannbf yannbf requested a review from shilman May 16, 2020 15:16
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and works great. Thanks for fixing this!

@shilman shilman merged commit 1e37270 into next May 17, 2020
@shilman shilman deleted the chore/build-package-improvements branch May 17, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants