cli: svelte stories homogenization #10704
Conversation
There was a problem hiding this comment.
LGTM ✅
Some of the framework apps have Welcome and Button components, used in template stories, in @storybook/FRAMEWORK/demo, and some others define these components in CLI templates directly. I think it could be great to pick a way and be consistent across all apps. Personally I vote for components in @storybook/FRAMEWORK/demo. What's your opinion on that?
I agree with that. We should be as consistent as possible across all frameworks. Shipping example components might be helpful for beginners but might also be considered noise which people would delete right away. I especially like that with the But I guess I'd go for @shilman @ndelangen which way do you think should be the way to go? Edit: Moving this discussion to #10723 please respond there 🚀 |
|
|
||
| <main> | ||
| <h1>Welcome to storybook</h1> | ||
| <p>This is a UI component dev environment for your app.</p> |
There was a problem hiding this comment.
Should we keep consistency on the content of the Welcome component? There is useful info in other components that I don't see here, such as telling users about hot module reloading, a link to storybook repo and explanation over the webpack config file.
Edit: Moving this discussion to #10723 please respond there 🚀
|
Also about keeping things in sync, some templates generate stories under Edit: Moving this discussion to #10723 please respond there 🚀 |
Issue:
We need similar stories after generation to run e2e against
Part of #10702