Change reference for jest-preset-angular/build/setupJest as per migration guide #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
addon: storyshots
documentation
patch:yes
shilman
approved these changes
May 11, 2020
|
@adover turns out this was a bad merge--there are more changes required to not break the storybook build. i'm going to revert this merge now. |
|
Apologies @shilman . Do you have any information on this and I can attempt to do a proper job! |
|
@adover no need to apologize. i shouldn't have merged it in the first place, and should have worked it out with you on the original PR, but missed the CI failure. what i did:
If you can get it working, I'd be happy to merge again. Thanks for your help and patience! |
shilman
added
angular
bug
and removed
documentation
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9072 - Affects addon-storyshots
What I did
Modified the path to jest-preset-angular/setupJest as per migration documentation https…://github.com/thymikee/jest-preset-angular/blob/5c071692d174d78639f952bf795bc06abd72d28c/CHANGELOG.md#migration-guide
How to test
This is testable by running within an Angular project which requires addon-storyshots
If your answer is yes to any of these, please make sure to include it in your PR.