Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-contexts: Move to deprecated-addons repo #10479

Merged
merged 11 commits into from
Apr 23, 2020
Merged

Conversation

ndelangen
Copy link
Member

Issue: addon-contexts is being replaced by core apis

What I did

REMOVE the addon

@ndelangen ndelangen added maintenance User-facing maintenance tasks addon: contexts labels Apr 20, 2020
@ndelangen ndelangen requested a review from shilman April 20, 2020 14:34
@ndelangen ndelangen self-assigned this Apr 20, 2020
@ndelangen ndelangen added this to the 6.0 milestone Apr 20, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HALLELUJAH! I'll add migration instructions onto this PR and then merge

@shilman shilman changed the title Remove/addon context Addon-contexts: Move to deprecated-addons repo Apr 20, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE. Feel free to merge once tests are passing

# Conflicts:
#	addons/contexts/package.json
#	examples/official-storybook/package.json
#	examples/preact-kitchen-sink/package.json
#	examples/vue-kitchen-sink/package.json
# Conflicts:
#	MIGRATION.md
#	addons/contexts/package.json
#	examples/official-storybook/package.json
#	examples/preact-kitchen-sink/package.json
#	examples/vue-kitchen-sink/package.json
@ndelangen ndelangen merged commit da22389 into next Apr 23, 2020
@ndelangen ndelangen deleted the remove/addon-context branch April 23, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: contexts maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants