Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Make source resilient to bad story ID's #10184

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 23, 2020

Issue: #7479

What I did

When users type <Story id="some-random"> the source addon currently crashes ungracefully. With this fix, it shows "no source found" instead.

How to test

See the MDX stories in official-storybook, which are currently broken on next.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shilman shilman changed the title Addon-docs: Make source resiient to bad story ID's Addon-docs: Make source resilient to bad story ID's Mar 23, 2020
@shilman shilman added this to the 6.0.0 milestone Mar 23, 2020
@shilman shilman merged commit 749ab01 into next Mar 23, 2020
@shilman shilman deleted the 7479-fix-bad-story-id branch March 23, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants