Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: title not set as informed in documentation #22211

Closed
muratcorlu opened this issue Apr 21, 2023 · 4 comments
Closed

[Bug]: title not set as informed in documentation #22211

muratcorlu opened this issue Apr 21, 2023 · 4 comments

Comments

@muratcorlu
Copy link
Contributor

Describe the bug

For setting <title> tag of the main html file, current document says just adding this to .storybook/main.js file will do the trick:

export const title = 'My awesome project';

But that doesn't work for me (v7.0.6).

To Reproduce

https://stackblitz.com/edit/github-jrebwy?file=.storybook%2Fmain.ts

One you run/build storybook, HTML title becomes:

<title>@storybook/cli - Storybook</title>

System

Environment Info:

  System:
    OS: macOS 13.3
    CPU: (8) arm64 Apple M1
  Binaries:
    Node: 16.19.1 - /usr/local/bin/node
    npm: 8.15.0 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 112.0.5615.49
    Safari: 16.4
  npmPackages:
    @storybook/addon-a11y: 7.0.6 => 7.0.6 
    @storybook/addon-actions: 7.0.6 => 7.0.6 
    @storybook/addon-essentials: 7.0.6 => 7.0.6 
    @storybook/addon-interactions: ^7.0.6 => 7.0.6 
    @storybook/addon-links: 7.0.6 => 7.0.6 
    @storybook/addon-mdx-gfm: ^7.0.6 => 7.0.6 
    @storybook/addon-storysource: 7.0.6 => 7.0.6 
    @storybook/addon-viewport: ^7.0.6 => 7.0.6 
    @storybook/jest: ^0.1.0 => 0.1.0 
    @storybook/testing-library: ^0.1.0 => 0.1.0 
    @storybook/web-components: 7.0.6 => 7.0.6 
    @storybook/web-components-vite: ^7.0.6 => 7.0.6

Additional context

No response

@shilman
Copy link
Member

shilman commented Apr 23, 2023

This looks like a bug in the documentation @jonniebigodes @ndelangen -- did we ever support this?

@ndelangen
Copy link
Member

No that's never worked AFAICS:
Screenshot 2023-04-25 at 08 31 21

@muratcorlu
Copy link
Contributor Author

That's sad. It was nice to see a simple solution to set the title. Because we really suffer from that and even some popular projects make hacks to work around it.

@jonniebigodes
Copy link
Contributor

@muratcorlu Sorry about this and the confusion around it 🙏 . For the time being, this is going to be removed from the documentation to prevent similar issues as you've experienced, and once we have a good way to address this, it will be properly documented.

Nonetheless, thank you so much for reaching out to us with your issue and letting us know of this small but rather crucial issue with the documentation.

Hope you have a great day.

Stay safe

@github-project-automation github-project-automation bot moved this from In Progress to Done in Learning Team Apr 26, 2023
YossiSaadi added a commit to mondaycom/vibe that referenced this issue Sep 10, 2024
it loads with "@storybook/cli" title, we need to update it. inspired by PRs mentioned in Storybook's issue: storybookjs/storybook#22211
YossiSaadi added a commit to mondaycom/vibe that referenced this issue Sep 22, 2024
it loads with "@storybook/cli" title, we need to update it. inspired by PRs mentioned in Storybook's issue: storybookjs/storybook#22211
YossiSaadi added a commit to mondaycom/vibe that referenced this issue Sep 23, 2024
it loads with "@storybook/cli" title, we need to update it. inspired by PRs mentioned in Storybook's issue: storybookjs/storybook#22211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants