-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in IE11 Storybook 6.4.9 #17057
Comments
As far as I know, Storybook 6.4 itself is compatible with IE11. We have a CI step that verifies that: https://www.chromatic.com/builds?appId=5def629a9aec2800201cd626 Are you using |
I have the same exact issue with 6.4.8 and 6.4.9 |
@shilman shilman The error is coming from react router which was introduced into the storybook router in 6.4. I think this is the culprit for breaking IE 11 support. I downgraded to 6.3.12 and storybook will start up again. However, the stories never finish loading due to a new error:
For reference I'm using storybook/html |
Thanks @inthegreenwild. I can confirm the problem. Storybook is built in two parts: the outer UI called the manager, and an inner iframe called the preview which is where your stories are rendered. Our CI tests that we didn't break the preview, but it does not test the manager. The react-router upgrade broke the manager UI, but we should be able to fix it. |
Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.10 containing PR #17141 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Tested in IE 11 and it's working, thanks! |
Fixes IE11 issues using storybookjs/storybook#17057 Uses webpack5 loader for storybook https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5 Updates dev deps Uses polyfill.io for storybook too Co-authored-by: Oliver Barnwell <[email protected]>
Fixes IE11 issues using storybookjs/storybook#17057 Uses webpack5 loader for storybook https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5 Updates dev deps Uses polyfill.io for storybook too Co-authored-by: Oliver Barnwell <[email protected]> feat: remove corejs
After updating Storybook to the last version (6.4.9), I become get an error in IE11 (in other browsers it works fine):
If i open it, I can see, that issue comes from unabling to destructuring object with variable initialization (my guess):
But as I can see from these dependencies, Storybook already use appropriate plugin to support this feature (line 69):
https://github.com/storybookjs/storybook/blob/next/lib/core-common/src/utils/babel.ts
I also have disabled Docs from Essentials addon:
Here's my main.js:
Any advice?
The text was updated successfully, but these errors were encountered: