Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to external site would navigate preview iframe with no way to reset #1122

Closed
danielduan opened this issue May 24, 2017 · 3 comments
Closed

Link to external site would navigate preview iframe with no way to reset #1122

danielduan opened this issue May 24, 2017 · 3 comments
Labels
bug ui

Comments

@danielduan
Copy link
Member

For a story that has a link to an external site, if the user clicks and navigates to the site, there's no way to return the preview iframe back except to refresh the page.

Story:

<a href="https://www.google.com">Click here to be banished forever!</a>
or 
<a href="/somewhere/far/far/away">Click here to get lost!</a>

Discovered this bug while playing with Lonely Planet's Storybook:
https://github.com/lonelyplanet/backpack-ui

I think we can fix it by detecting the location of the iframe when navigating to a new story and reload the entire iframe if it's in the wrong place.
@blairanderson
Copy link
Contributor

I am having this problem as well.

@ndelangen
Copy link
Member

#7 (comment)

I don't think we should touch this behavior tbh. It's the web. You made an <a> without a target.. This is what happens.

But having said that.. You could easily wrap a decorator or addon to preventDefault() that.

blairanderson added a commit to blairanderson/storybook that referenced this issue Aug 13, 2017
@blairanderson
links should navigate in the parent window
26f3134 
I found that creating normal `<a target="_blank" href="https://www.google.com">foo</a>` links inside of a story would update the iframe and not actually take the user out to the external link

`<base>`tag is supported by all browsers https://stackoverflow.com/a/2656798/1536309 

fixes storybookjs#1122
@blairanderson blairanderson mentioned this issue Aug 13, 2017
Merged
@Hypnosphi
Copy link
Member

#1650 solves this while respecting usual browser behaviour

@Hypnosphi Hypnosphi reopened this Aug 14, 2017
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
@adrukh adrukh mentioned this issue Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@adrianblynch adrianblynch mentioned this issue Nov 5, 2022
Open
@Bhanditz Bhanditz mentioned this issue Nov 5, 2022
Open
This was referenced Dec 25, 2022
Open
Open
This was referenced Dec 25, 2022
Open
Open
@adrukh adrukh mentioned this issue Dec 26, 2022
Open
@adrianblynch adrianblynch mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shilman @blairanderson @danielduan @ndelangen @Hypnosphi