Merge pull request #30232 from storybookjs/jeppe/fix-bench-base-with-…

…slash Benchmark: Fix script breaking when base branch has slashes
storybookjs · Jan 10, 2025 · f43a567 · f43a567
2 parents 1389976 + f53509d
commit f43a567
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -256,8 +256,6 @@ jobs:
                   yarn bench-packages --upload
       - store_artifacts:
           path: bench/packages/results.json
-      - store_artifacts:
-          path: bench/packages/compare-with-<< pipeline.parameters.ghBaseBranch >>.json
       - report-workflow-on-failure
       - cancel-workflow-on-failure
   check:

diff --git a/docs/writing-tests/test-addon.mdx b/docs/writing-tests/test-addon.mdx
@@ -434,12 +434,6 @@ If the URLs are not working when running tests in CI, you should ensure the Stor
 
 If your stories use assets in the public directory and you're not using the default public directory location (`public`), you need to adjust the Vitest configuration to include the public directory. You can do this by providing the [`publicDir` option in the Vitest configuration file](https://vitejs.dev/config/shared-options.html#publicdir).
 
-### How do I apply custom Vite configuration?
-
-Your Storybook project's Vite configuration (in [`viteFinal`](../api/main-config/main-config-vite-final.mdx) in your `.storybook/main.js|ts` file) is automatically applied to your Vitest configuration, with one exception: the plugins.
-
-If you are running any plugins in `viteFinal`, you will likely also need to run those in the Vitest configuration.
-
 ### How do I isolate Storybook tests from others?
 
 Some projects might contain a `test` property in their Vite configuration. Because the Vitest configuration used by this plugin extends that Vite config, the `test` properties are merged. This lack of isolation can cause issues with your Storybook tests.

diff --git a/scripts/bench/bench-packages.ts b/scripts/bench/bench-packages.ts
@@ -460,16 +460,6 @@ const run = async () => {
   if (options.baseBranch) {
     const comparisonResults = await compareResults({ results, baseBranch: options.baseBranch });
     const resultsAboveThreshold = filterResultsByThresholds(comparisonResults);
-    await saveLocally({
-      filename: `compare-with-${options.baseBranch}.json`,
-      results: comparisonResults,
-      diff: true,
-    });
-    await saveLocally({
-      filename: `comparisons-above-threshold-with-${options.baseBranch}.json`,
-      results: resultsAboveThreshold,
-      diff: true,
-    });
     if (options.pullRequest) {
       await uploadToGithub({
         results: resultsAboveThreshold,