Merge pull request #25828 from storybookjs/norbert/fix-testflag-addon…

…-filtering Core: Fix `--test` must be passed for `build.test` values to be set.
storybookjs · Jan 31, 2024 · d9e1720 · d9e1720
2 parents 69fcccd + b7127d5
commit d9e1720
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/code/frameworks/angular/src/builders/build-storybook/index.ts b/code/frameworks/angular/src/builders/build-storybook/index.ts
@@ -49,6 +49,7 @@ export type StorybookBuilderOptions = JsonObject & {
     | 'configDir'
     | 'loglevel'
     | 'quiet'
+    | 'test'
     | 'webpackStatsJson'
     | 'disableTelemetry'
     | 'debugWebpack'
@@ -87,6 +88,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
         configDir,
         docs,
         loglevel,
+        test,
         outputDir,
         quiet,
         enableProdMode = true,
@@ -104,6 +106,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
         ...(docs ? { docs } : {}),
         loglevel,
         outputDir,
+        test,
         quiet,
         enableProdMode,
         disableTelemetry,

diff --git a/code/lib/core-server/src/presets/common-override-preset.ts b/code/lib/core-server/src/presets/common-override-preset.ts
@@ -51,9 +51,11 @@ const createTestBuildFeatures = (value: boolean): Required<TestBuildFlags> => ({
 export const build: PresetProperty<'build'> = async (value, options) => {
   return {
     ...value,
-    test: {
-      ...createTestBuildFeatures(!!options.test),
-      ...value?.test,
-    },
+    test: options.test
+      ? {
+          ...createTestBuildFeatures(!!options.test),
+          ...value?.test,
+        }
+      : createTestBuildFeatures(false),
   };
 };