Merge pull request #53 from kadirahq/fix-proptables-option

Handle propTables=false properly
storybookjs · Aug 11, 2016 · d85d261 · d85d261
2 parents e2bf9c0 + 7d235fb
commit d85d261
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/components/Story.js b/src/components/Story.js
@@ -224,7 +224,7 @@ export default class Story extends React.Component {
   _getPropTables() {
     const types = new Map();
 
-    if (this.props.propTables === false) {
+    if (this.props.propTables === null) {
       return null;
     }
 

diff --git a/src/index.js b/src/index.js
@@ -25,6 +25,13 @@ export default {
       ..._options
     };
 
+    // props.propTables can only be either an array of components or null
+    // propTables option is allowed to be set to 'false' (a boolean)
+    // if the option is false, replace it with null to avoid react warnings
+    if (!options.propTables) {
+      options.propTables = null;
+    }
+
     this.add(storyName, (context) => {
       const props = {
         info,