Merge pull request #1525 from storybooks/hmr-warning-on-storiesOf

Add warning when module is missing in storiesOf
storybookjs · Jul 26, 2017 · 949f62f · 949f62f
2 parents de75c5d + d6f1b89
commit 949f62f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/app/react/src/client/preview/client_api.js b/app/react/src/client/preview/client_api.js
@@ -34,6 +34,13 @@ export default class ClientApi {
       throw new Error('Invalid or missing kind provided for stories, should be a string');
     }
 
+    if (!m) {
+      // eslint-disable-next-line no-console
+      console.warn(
+        `Missing 'module' parameter for story with a kind of '${kind}'. It will break your HMR`
+      );
+    }
+
     if (m && m.hot) {
       m.hot.dispose(() => {
         this._storyStore.removeStoryKind(kind);

diff --git a/app/vue/src/client/preview/client_api.js b/app/vue/src/client/preview/client_api.js
@@ -30,6 +30,10 @@ export default class ClientApi {
       throw new Error('Invalid or missing kind provided for stories, should be a string');
     }
 
+    if(!m) {
+      console.warn(`Missing 'module' parameter for story with a kind of '${kind}'. It will break your HMR`);
+    }
+
     if (m && m.hot) {
       m.hot.dispose(() => {
         this._storyStore.removeStoryKind(kind);

diff --git a/lib/ui/package.json b/lib/ui/package.json
@@ -33,7 +33,6 @@
     "react-komposer": "^2.0.0",
     "react-modal": "^1.7.7",
     "react-split-pane": "^0.1.63",
-    "react-split-pane": "^0.1.65",
     "redux": "^3.6.0"
   },
   "devDependencies": {