Merge pull request #20788 from storybookjs/fix/new-frameworks-automig…

…ration-in-angular CLI: Fix new-frameworks automigration in angular projects
storybookjs · Jan 26, 2023 · 8bbcca3 · 8bbcca3
2 parents bbc8f9b + 9b56a36
commit 8bbcca3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/code/lib/cli/src/automigrate/fixes/new-frameworks.test.ts b/code/lib/cli/src/automigrate/fixes/new-frameworks.test.ts
@@ -91,6 +91,18 @@ describe('new-frameworks fix', () => {
       ).resolves.toBeFalsy();
     });
 
+    it('in sb 7 with correct structure already', async () => {
+      const packageJson = { dependencies: { '@storybook/angular': '^7.0.0' } };
+      await expect(
+        checkNewFrameworks({
+          packageJson,
+          main: {
+            framework: '@storybook/angular',
+          },
+        })
+      ).resolves.toBeFalsy();
+    });
+
     // TODO: once we have a @storybook/vue-vite framework, we should remove this test
     it('in sb 7 with vue and vite', async () => {
       const packageJson = {

diff --git a/code/lib/cli/src/automigrate/fixes/new-frameworks.ts b/code/lib/cli/src/automigrate/fixes/new-frameworks.ts
@@ -183,6 +183,10 @@ export const newFrameworks: Fix<NewFrameworkRunOptions> = {
       `);
     }
 
+    if (!dependenciesToRemove.length && !dependenciesToAdd.length) {
+      return null;
+    }
+
     return {
       main,
       dependenciesToAdd,