Merge pull request #1 from storybooks/release/3.3

Release/3.3

.circleci/config.yml

@@ -0,0 +1,175 @@
+defaults: &defaults
+  working_directory: /tmp/storybook
+  docker:
+    - image: node:8
+
+version: 2
+dependencies:
+  pre:
+    - yarn global add npm
+jobs:
+  validate:
+    <<: *defaults
+    steps:
+      - run:
+          name: "Checking Versions"
+          command: |
+            node --version
+            npm --version
+            yarn --version
+  build:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - save_cache:
+          key: root-dependencies-{{ checksum "package.json" }}
+          paths:
+            - node_modules
+      - restore_cache:
+          keys:
+            - package-dependencies-{{ checksum "package.json" }}
+            - package-dependencies-
+      - run:
+          name: "Bootstrapping"
+          command: |
+            yarn bootstrap -- --all
+      - save_cache:
+          key: package-dependencies-{{ checksum "package.json" }}
+          paths:
+            - app/**/node_modules
+            - docs/**/node_modules
+            - examples/**/node_modules
+            - lib/**/node_modules
+  example-kitchen-sinks:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - run:
+          name: "Bootstrapping"
+          command: |
+            yarn bootstrap -- --core
+      - run:
+          name: "Build react kitchen-sink"
+          command: |
+            cd examples/cra-kitchen-sink && yarn build-storybook
+      - run:
+          name: "Build vue kitchen-sink"
+          command: |
+            cd examples/vue-kitchen-sink && yarn build-storybook
+  example-react-native:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - run:
+          name: "Bootstrapping packages"
+          command: |
+            yarn bootstrap -- --core --reactnative
+      - run:
+          name: "Running react-native"
+          command: |
+            echo "TODO"
+  docs:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - run:
+          name: "Bootstrapping"
+          command: |
+            yarn bootstrap -- --docs
+      - run:
+          name: "Running docs"
+          command: |
+            yarn docs:build
+  lint:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - run:
+          name: "Linting"
+          command: |
+            yarn lint
+  unit-test:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - root-dependencies-{{ checksum "package.json" }}
+            - root-dependencies-
+      - run:
+          name: "Install root dependencies"
+          command: |
+            yarn install
+      - run:
+          name: "Bootstrapping"
+          command: |
+            yarn bootstrap -- --core --reactnative
+      - run:
+          name: "Unit testing"
+          command: |
+            yarn test -- --all --coverage --runInBand
+            yarn coverage
+  deploy:
+    <<: *defaults
+    steps:
+      - run:
+          name: "Deploy"
+          command: |
+            echo "TODO"
+workflows:
+  version: 2
+  build_accept_deploy:
+    jobs:
+      - validate
+      - build
+      - example-kitchen-sinks
+      - example-react-native
+      - docs
+      - lint
+      - unit-test
+      # - deploy:
+      #     type: approval
+      #     requires:
+      #       - lint
+      #       - unit-test
+      #       - docs

.editorconfig

@@ -0,0 +1,8 @@
+root = true
+
+[*]
+end_of_line = lf
+
+[*.{js,json}]
+indent_style = space
+indent_size = 2

.eslintignore

@@ -2,7 +2,7 @@ dist
 build
 coverage
 node_modules
-**/example/**
+addons/**/example/**
 app/**/demo/**
 docs/public
 

.eslintrc-markdown.js

@@ -51,6 +51,9 @@ module.exports = {
     'react/react-in-jsx-scope': ignore,
     'react/jsx-filename-extension': ignore,
     'jsx-a11y/accessible-emoji': ignore,
+    'jsx-a11y/href-no-hash': ignore,
+    'jsx-a11y/label-has-for': ignore,
+    'jsx-a11y/anchor-is-valid': ['warn', { aspects: ['invalidHref'] }],
     'react/no-unescaped-entities': ignore,
   },
 };

.eslintrc.js

@@ -27,22 +27,26 @@ module.exports = {
         singleQuote: true,
       },
     ],
-    quotes: [warn, 'single'],
+    quotes: [warn, 'single', { avoidEscape: true }],
     'class-methods-use-this': ignore,
     'arrow-parens': [warn, 'as-needed'],
     'space-before-function-paren': ignore,
     'import/no-unresolved': warn,
     'import/extensions': [
+      // because of highlight.js and fuse.js
       warn,
       {
         js: 'never',
         json: 'always',
       },
     ],
     'import/no-extraneous-dependencies': [
-      warn,
+      error,
       {
         devDependencies: [
+          'examples/**',
+          '**/example/**',
+          '*.js',
           '**/*.test.js',
           '**/scripts/*.js',
           '**/stories/*.js',
@@ -66,6 +70,9 @@ module.exports = {
       },
     ],
     'jsx-a11y/accessible-emoji': ignore,
+    'jsx-a11y/href-no-hash': ignore,
+    'jsx-a11y/label-has-for': ignore,
+    'jsx-a11y/anchor-is-valid': ['warn', { aspects: ['invalidHref'] }],
     'react/no-unescaped-entities': ignore,
   },
 };

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,6 +2,12 @@ Issue:
 
 ## What I did
 
+## How to test
 
+Is this testable with jest or storyshots?
 
-## How to test
+Does this need a new example in the kitchen sink apps?
+
+Does this need an update to the documentation?
+
+If your answer is yes to any of these, please make sure to include it in your PR.

.gitignore

@@ -1,6 +1,7 @@
 node_modules
 *.log
 .idea
+.vscode
 npm-shrinkwrap.json
 dist
 .tern-port
@@ -11,8 +12,9 @@ coverage/
 *.lerna_backup
 build
 packages/examples/automated-*
-yarn.lock
 /**/LICENSE
 docs/public
 packs/*.tgz
 package-lock.json
+.nvmrc
+storybook-static