Skip to content

Commit

Permalink
remove addon onboarding logic
Browse files Browse the repository at this point in the history
  • Loading branch information
yannbf committed Jun 8, 2023
1 parent b7fd441 commit 1eb72b9
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 31 deletions.
11 changes: 1 addition & 10 deletions code/lib/cli/src/generators/NEXTJS/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,7 @@ import { baseGenerator } from '../baseGenerator';
import type { Generator } from '../types';

const generator: Generator = async (packageManager, npmOptions, options) => {
await baseGenerator(
packageManager,
npmOptions,
options,
'react',
{
extraAddons: ['@storybook/addon-onboarding'],
},
'nextjs'
);
await baseGenerator(packageManager, npmOptions, options, 'react', undefined, 'nextjs');
};

export default generator;
1 change: 0 additions & 1 deletion code/lib/cli/src/generators/REACT/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ const generator: Generator = async (packageManager, npmOptions, options) => {

await baseGenerator(packageManager, npmOptions, options, 'react', {
extraPackages,
extraAddons: ['@storybook/addon-onboarding'],
});
};

Expand Down
5 changes: 1 addition & 4 deletions code/lib/cli/src/generators/REACT_SCRIPTS/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ const generator: Generator = async (packageManager, npmOptions, options) => {
}

const version = versions['@storybook/preset-create-react-app'];
const extraAddons = [
`@storybook/preset-create-react-app@${version}`,
'@storybook/addon-onboarding',
];
const extraAddons = [`@storybook/preset-create-react-app@${version}`];

if (!isCra5OrHigher) {
throw new Error(dedent`
Expand Down
4 changes: 1 addition & 3 deletions code/lib/cli/src/generators/WEBPACK_REACT/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import { baseGenerator } from '../baseGenerator';
import type { Generator } from '../types';

const generator: Generator = async (packageManager, npmOptions, options) => {
await baseGenerator(packageManager, npmOptions, options, 'react', {
extraAddons: ['@storybook/addon-onboarding'],
});
await baseGenerator(packageManager, npmOptions, options, 'react');
};

export default generator;
9 changes: 0 additions & 9 deletions code/lib/cli/src/initiate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,13 +320,6 @@ async function doInitiate(options: CommandOptions, pkg: PackageJson): Promise<vo

logger.log('\nFor more information visit:', chalk.cyan('https://storybook.js.org'));

const isReactWebProject =
projectType === ProjectType.REACT_SCRIPTS ||
projectType === ProjectType.REACT ||
projectType === ProjectType.WEBPACK_REACT ||
projectType === ProjectType.REACT_PROJECT ||
projectType === ProjectType.NEXTJS;

const shouldRunDev =
projectType !== ProjectType.REACT_NATIVE &&
process.env.CI !== 'true' &&
Expand Down Expand Up @@ -371,8 +364,6 @@ async function doInitiate(options: CommandOptions, pkg: PackageJson): Promise<vo
port: 6006,
open: true,
quiet: true,
// TODO: change this logic to all frameworks once the idea is validated
initialPath: isReactWebProject ? '/onboarding' : undefined,
});
}
}
Expand Down
4 changes: 0 additions & 4 deletions scripts/verdaccio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ packages:
access: $all
publish: $all
proxy: npmjs
'@storybook/addon-onboarding':
access: $all
publish: $all
proxy: npmjs
'@storybook/mdx1-csf':
access: $all
publish: $all
Expand Down

0 comments on commit 1eb72b9

Please sign in to comment.