Merge pull request #29175 from JSMike/patch-1

Fix composed storybook TooltipLinkList bug where href isn't passed forward
storybookjs · Sep 24, 2024 · 1a50094 · 1a50094
2 parents caa4ff3 + 91c2e9d
commit 1a50094
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/code/core/src/components/components/tooltip/ListItem.tsx b/code/core/src/components/components/tooltip/ListItem.tsx
@@ -169,7 +169,7 @@ const getItemProps = memoize(100)((onClick, href, LinkWrapper) => ({
 
 export type LinkWrapperType = (props: any) => ReactNode;
 
-export interface ListItemProps extends Omit<ComponentProps<typeof Item>, 'href' | 'title'> {
+export interface ListItemProps extends Omit<ComponentProps<typeof Item>, 'title'> {
   loading?: boolean;
   title?: ReactNode;
   center?: ReactNode;

diff --git a/code/core/src/components/components/tooltip/TooltipLinkList.tsx b/code/core/src/components/components/tooltip/TooltipLinkList.tsx
@@ -22,7 +22,7 @@ export interface Link extends Omit<ListItemProps, 'onClick'> {
   id: string;
   onClick?: (
     event: SyntheticEvent,
-    item: Pick<ListItemProps, 'id' | 'active' | 'disabled' | 'title'>
+    item: Pick<ListItemProps, 'id' | 'active' | 'disabled' | 'title' | 'href'>
   ) => void;
 }
 
@@ -31,11 +31,11 @@ interface ItemProps extends Link {
 }
 
 const Item = ({ id, onClick, ...rest }: ItemProps) => {
-  const { active, disabled, title } = rest;
+  const { active, disabled, title, href } = rest;
 
   const handleClick = useCallback(
-    (event: SyntheticEvent) => onClick?.(event, { id, active, disabled, title }),
-    [onClick, id, active, disabled, title]
+    (event: SyntheticEvent) => onClick?.(event, { id, active, disabled, title, href }),
+    [onClick, id, active, disabled, title, href]
   );
 
   return <ListItem id={`list-item-${id}`} {...rest} {...(onClick && { onClick: handleClick })} />;