Skip to content

Commit

Permalink
Merge pull request #19599 from storybookjs/tom/sb-813-move-remaining-…
Browse files Browse the repository at this point in the history
…examples-to-old-examples

Move examples -> test-storybooks
  • Loading branch information
tmeasday authored Oct 25, 2022
2 parents 39662b1 + 9a92922 commit 03551d1
Show file tree
Hide file tree
Showing 172 changed files with 131,817 additions and 6,671 deletions.
84 changes: 0 additions & 84 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,38 +125,6 @@ jobs:
- code/ui
- code/renderers
- code/presets
chromatic:
executor: sb_node_16_browsers
parallelism: 15
steps:
# Keep using default checkout because Chromatic needs some git history to work properly
- checkout
- attach_workspace:
at: .
- run:
name: chromatic
command: |
cd code
yarn run-chromatics
examples:
executor:
class: medium+
name: sb_node_16_browsers
parallelism: 3
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- attach_workspace:
at: .
- run:
name: examples
command: |
cd code
yarn build-storybooks --all
- persist_to_workspace:
root: .
paths:
- code/built-storybooks
publish:
executor:
class: medium
Expand All @@ -175,30 +143,6 @@ jobs:
root: .
paths:
- .verdaccio-cache
# NOTE: this currently tests each story in docs mode, which doesn't make sense any more as stories
# can no longer run in docs mode. Instead we should probably change the test runner to test each
# docs entry if you run it in `VIEW_MODE=docs`
# e2e-tests-sb-docs:
# executor:
# class: large
# name: sb_cypress_8_node_14
# parallelism: 8
# steps:
# - git-shallow-clone/checkout_advanced:
# clone_options: '--depth 1 --verbose'
# - attach_workspace:
# at: .
# - run:
# name: Running local registry
# command: yarn local-registry --port 6001 --open
# background: true
# - run:
# name: Wait for registry
# command: yarn wait-on http://localhost:6001
# - run:
# name: Run smoke tests
# command: yarn test:e2e-framework angular_modern_inline_rendering --test-runner --docs-mode
# no_output_timeout: 5m
cra-bench:
executor:
class: medium+
Expand Down Expand Up @@ -279,25 +223,6 @@ jobs:
- store_artifacts:
path: /tmp/sb-bench.tar.gz
destination: sb-bench.tar.gz
smoke-tests:
executor:
class: medium+
name: sb_node_16_browsers
environment:
# Disable ESLint when running smoke tests to improve perf + As of CRA 4.0.3, CRA kitchen sinks are throwing
# because of some ESLint warnings, related to: https://github.com/facebook/create-react-app/pull/10590
DISABLE_ESLINT_PLUGIN: 'true'
parallelism: 4
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- attach_workspace:
at: .
- run:
name: smoke tests
command: |
cd code
yarn smoketest-storybooks --all
lint:
executor:
class: medium
Expand Down Expand Up @@ -472,12 +397,6 @@ workflows:
- check:
requires:
- build
- examples:
requires:
- build
- smoke-tests:
requires:
- build
- unit-tests:
requires:
- build
Expand All @@ -487,9 +406,6 @@ workflows:
- coverage:
requires:
- unit-tests
- chromatic:
requires:
- examples
- publish:
requires:
- build
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@ junit.xml
!/**/.yarn/versions
/**/.pnp.*
!/node_modules

# test-storybooks
test-storybooks/ember-cli/ember-output
test-storybooks/angular-cli/addon-jest.testresults.json
2 changes: 0 additions & 2 deletions code/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ lib/**/dll
built-storybooks
cypress/videos
cypress/screenshots
examples/ember-cli/ember-output
.verdaccio-cache
tsconfig.tsbuildinfo
examples/angular-cli/addon-jest.testresults.json
junit.xml
.next

Expand Down
21 changes: 0 additions & 21 deletions code/examples/README.md

This file was deleted.

40 changes: 0 additions & 40 deletions code/examples/doc-blocks/package.json

This file was deleted.

66 changes: 0 additions & 66 deletions code/examples/ember-cli/package.json

This file was deleted.

45 changes: 0 additions & 45 deletions code/examples/external-docs/package.json

This file was deleted.

35 changes: 0 additions & 35 deletions code/examples/server-kitchen-sink/package.json

This file was deleted.

20 changes: 0 additions & 20 deletions code/examples/standalone-preview/package.json

This file was deleted.

1 change: 1 addition & 0 deletions code/frameworks/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"ts-dedent": "^2.0.0"
},
"devDependencies": {
"ember-source": "~3.28.1",
"typescript": "~4.6.3"
},
"peerDependencies": {
Expand Down
Loading

0 comments on commit 03551d1

Please sign in to comment.