Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace example app with an expo one #435

Merged
merged 5 commits into from
Feb 25, 2023

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Feb 25, 2023

Issue:

What I did

replace example app with an expo app since it simplifies upgrading etc.

@socket-security
Copy link

socket-security bot commented Feb 25, 2023

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
[email protected] (upgraded) postinstall package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-actions/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-backgrounds/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-controls/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-knobs/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-notes/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native-server/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], examples/expo-example/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected]
[email protected] (upgraded) postinstall package.json via @storybook/[email protected], @testing-library/[email protected], examples/expo-example/package.json via @storybook/[email protected]
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
@react-native-community/[email protected] (upgraded) react-native package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
[email protected] (upgraded) react-native package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], addons/ondevice-actions/package.json, addons/ondevice-backgrounds/package.json, addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], addons/ondevice-notes/package.json, app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected]
[email protected] (added) semver package.json via [email protected], examples/expo-example/package.json via [email protected]
[email protected] (added) semver package.json via @react-native-community/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @typescript-eslint/[email protected], @typescript-eslint/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-controls/package.json via @storybook/[email protected], app/react-native/package.json via [email protected], app/react-native-server/package.json via @storybook/[email protected], examples/expo-example/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected]
[email protected] (upgraded) jest package.json via [email protected], [email protected], [email protected], app/react-native/package.json
[email protected] (upgraded) jest package.json via [email protected], [email protected], [email protected], [email protected], app/react-native/package.json via [email protected]
⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
@sinclair/[email protected] (added) Function compiler/compiler.js package.json via @emotion/[email protected], @jest/[email protected], @react-native-async-storage/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
@sinclair/[email protected] (added) Function errors/errors.js package.json via @emotion/[email protected], @jest/[email protected], @react-native-async-storage/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
@sinclair/[email protected] (added) Function value/cast.js package.json via @emotion/[email protected], @jest/[email protected], @react-native-async-storage/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
@sinclair/[email protected] (added) Function value/check.js package.json via @emotion/[email protected], @jest/[email protected], @react-native-async-storage/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
@sinclair/[email protected] (added) Function value/create.js package.json via @emotion/[email protected], @jest/[email protected], @react-native-async-storage/[email protected], @types/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], addons/ondevice-actions/package.json via [email protected], addons/ondevice-backgrounds/package.json via [email protected], addons/ondevice-controls/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-knobs/package.json via @emotion/[email protected], [email protected], [email protected], addons/ondevice-notes/package.json via [email protected], app/react-native/package.json via @emotion/[email protected], @react-native-async-storage/[email protected], [email protected], [email protected], [email protected], [email protected], examples/expo-example/package.json via @react-native-async-storage/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected]
@storybook/[email protected] (upgraded) Function dist/cjs/index.js package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-actions/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-backgrounds/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-controls/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-knobs/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-notes/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native-server/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], examples/expo-example/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected]
@storybook/[email protected] (upgraded) Function dist/esm/index.js package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-actions/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-backgrounds/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], addons/ondevice-controls/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-knobs/package.json via @storybook/[email protected], @storybook/[email protected], addons/ondevice-notes/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], app/react-native-server/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], examples/expo-example/package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected]
[@storybook/[email protected]](https://socket.dev/npm/package/@storybook/

@dannyhw dannyhw merged commit 767914f into next-6.0 Feb 25, 2023
@dannyhw dannyhw deleted the feat/replace-example-with-expo-app branch February 25, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant