Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for infinite global decorators #398

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Nov 16, 2022

Issue: #185

What I did

Added clear decorators to the requires file and a ignore for the warning it throws.
There is probably a better fix but this will fix it for those using the beta now.
Expect a future PR with a real fix.

How to test

Please explain how to test your changes and consider the following questions

  • run the example and cause HMR from a story, it shouldn't cause the padding to increase each time

@dannyhw dannyhw self-assigned this Nov 16, 2022
@dannyhw dannyhw merged commit 40e10b6 into next-6.0 Nov 17, 2022
@dannyhw dannyhw deleted the fix/global-decorators branch February 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant