Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react native server v6 (experimental) #393

Merged
merged 16 commits into from
Dec 2, 2022

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Nov 5, 2022

Issue:

What I did

  • updated react-native-server
  • added back websocket code into storybook/react-native

image

TODO:

  • get host/port from main.js config
  • resolve hacks mentioned below

How to test

  • run from example yarn storybook-server
  • and the app

hacks:

  • lots of hacks needed currently to get this working
    - in node_modules/@storybook/api/dist/esm/modules/refs.js:76
    - var _URL = new URL(source || location.origin),
  • node_modules/telejson/dist/cjs/index.js
    • var isRunningInBrowser = false;
  • node_modules/@storybook/manager-webpack4/dist/cjs/presets/manager-preset.js:96
    • delete envs from line 95
    • var envs = { NODE_PATH: process.env.NODE_PATH || '' };
    • comment out line 107:

@dannyhw dannyhw changed the title Feat/react native server feat: react native server v6 Nov 5, 2022
@dannyhw dannyhw changed the title feat: react native server v6 feat: react native server v6 (experimental) Nov 5, 2022
@socket-security
Copy link

socket-security bot commented Nov 17, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@jgornick
Copy link
Contributor

Hey @dannyhw! If I understand correctly, this will allow us to control/navigate stories via a web browser and have them reflect on the device/simulator?

@dannyhw
Copy link
Member Author

dannyhw commented Nov 17, 2022

@jgornick yes thats the idea, the functionality should be similar to the version of react-native-server in v5.3

@dannyhw dannyhw force-pushed the feat/react-native-server branch from ae231a0 to c2c4001 Compare November 20, 2022 18:46
@stevoland
Copy link
Contributor

Lovely to see this. Appreciate your efforts, keep it up!

@dannyhw dannyhw marked this pull request as ready for review November 30, 2022 16:44
@dannyhw dannyhw self-assigned this Nov 30, 2022
@dannyhw dannyhw merged commit e730939 into next-6.0 Dec 2, 2022
@dannyhw dannyhw deleted the feat/react-native-server branch February 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants